h5 option for data input - #350
Open
nicholebarry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can now read h5 files for input. This has yet to be extended to the model transfer, though hypothetically this is easily doable.
I am not super happy with the naming of things. The h5 reader is internal to the
uvfits_readto have as little footprint as possible. Perhaps we should change the name ofuvfits_readto be more general.Reading data is easy enough, but generating the metadata in the correct format required bespoke code.
One thing of note. IDL will not read h5 files that have been compressed. It is generally default to compress h5 files in pyuvdata, so
data_compression=None,flags_compression=None,nsample_compression=Nonemust be set. I need to think of a good way to warn the user, but haven't found a good way.