Closed
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up the infrustructure for the incoming refactors required for the row-based permission system. Main idea here is to create a data access layer for each type such that permissions can be consistently managed and applied. For this, auth.util.js was modified to inject the user's permissions into the context, and a buildAuthorizationFilter method was added. The Demonstration, Amendment, and Extension resolvers were updated by creating a set of data access methods such as getDemonstration and getManyDemonstrations. In those functions, the authorization filter is applied by "AND"ing it to the original prisma where clause. the permission filters themselves are expressed as a mapping between the Permission's name and a fragment of a prisma where clause. Multiple permissions get "OR"ed together, such that their accesses act permissively (they are UNIONed, rather than INTERSECTED).
The associated queries and helpers were chunked such that they can be tested individually. At this moment, a migration is required to initialize the permission assignments and a further edit to auth.util will likely need to be done in order to initialize new users with the appropriate role; will update that here shortly.