Refactor: improve encapsulation in FilterArguments#196
Closed
blascosmog wants to merge 1 commit intoEndava:masterfrom
Closed
Refactor: improve encapsulation in FilterArguments#196blascosmog wants to merge 1 commit intoEndava:masterfrom
blascosmog wants to merge 1 commit intoEndava:masterfrom
Conversation
Contributor
|
Apologies, but this PR does not bring any value. It's just reformatting code. And the static choice was deliberate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
FilterArgumentsclass to improve encapsulation and readability. The main changes involve converting previously static fields to instance fields, reformatting annotations for better clarity, and updating Javadoc comments for improved documentation.Encapsulation improvements:
FUZZERS_TO_BE_RUN,SECOND_PHASE_FUZZERS_TO_BE_RUN,ALL_CATS_FUZZERS, andPATHS_TO_INCLUDEfrom static fields to private instance fields, reducing global state and improving object-oriented design.Annotation and formatting updates:
@CommandLine.Optionannotations for all command-line arguments to use a more readable style, grouping argument names and aligning descriptions.Documentation improvements:
Minor cleanup: