Skip to content

Refactor: improve encapsulation in FilterArguments#196

Closed
blascosmog wants to merge 1 commit intoEndava:masterfrom
blascosmog:improve-encapsulation
Closed

Refactor: improve encapsulation in FilterArguments#196
blascosmog wants to merge 1 commit intoEndava:masterfrom
blascosmog:improve-encapsulation

Conversation

@blascosmog
Copy link

This pull request refactors the FilterArguments class to improve encapsulation and readability. The main changes involve converting previously static fields to instance fields, reformatting annotations for better clarity, and updating Javadoc comments for improved documentation.

Encapsulation improvements:

  • Changed FUZZERS_TO_BE_RUN, SECOND_PHASE_FUZZERS_TO_BE_RUN, ALL_CATS_FUZZERS, and PATHS_TO_INCLUDE from static fields to private instance fields, reducing global state and improving object-oriented design.

Annotation and formatting updates:

  • Reformatted @CommandLine.Option annotations for all command-line arguments to use a more readable style, grouping argument names and aligning descriptions.
  • Reformatted enum and method documentation to improve readability and consistency throughout the file. [1] [2] [3] [4] [5] [6] [7]

Documentation improvements:

  • Updated Javadoc comments for methods to clarify return values and provide more detailed descriptions, especially for methods handling filters and skip lists. [1] [2] [3] [4] [5] [6]

Minor cleanup:

  • Removed unnecessary blank lines and improved formatting for better code maintainability.

@en-milie
Copy link
Contributor

Apologies, but this PR does not bring any value. It's just reformatting code. And the static choice was deliberate.

@en-milie en-milie closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants