feat: show result count on colorbox swatch filter options in Hyva theme#99
Open
ahuininga-orisha wants to merge 1 commit into
Open
feat: show result count on colorbox swatch filter options in Hyva theme#99ahuininga-orisha wants to merge 1 commit into
ahuininga-orisha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Tweakwise, a filter attribute can be configured to show the number of matching products next to each option (the "Show amount of results" setting). For Colorbox-type filters this worked in the Luma theme but was silently missing in the Hyvä theme — shoppers saw the colored swatches with no counts at all.
This fix brings the Hyvä colorbox filter in line with Luma: when "Show amount of results" is enabled in the filter template, each swatch option now shows a
(N)count below the color box.Changes
src/view/frontend/templates/product/layered/swatch.phtmlshouldDisplayProductCountOnLayer()is truesrc/view/frontend/templates/product/layered/swatch.phtmlflex-col items-centerso the count stacks below the swatch boxHow to test
Scenario 1 — Count is shown when "Show amount of results" is enabled
bin/magento cache:clean.(N)count below the color box.Scenario 2 — Count is hidden when "Show amount of results" is disabled
bin/magento cache:clean.Scenario 3 — Luma theme is unaffected