Skip to content

fix: strip non-XML output from feed response to prevent script tag injection #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahuininga-orisha wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: strip non-XML output from feed response to prevent script tag injection #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Controller/Feed/Export.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,17 @@ public function execute(): Response
$store = $this->storeManager->getStore($storeId);
}

// Discard any output already buffered by other modules (e.g. Stape GTM setting
// cookies) before we start streaming the XML feed. Without this, buffered garbage
// can be flushed to the client ahead of the <?xml declaration, producing an invalid
// feed. We then set the Content-Type header explicitly since headers may not have
// been sent yet, and FeedContent writes directly to php://output bypassing OB.
while (ob_get_level()) {
ob_end_clean();
}

header('Content-Type: application/xml; charset=UTF-8');

// @phpstan-ignore-next-line
(new FeedContent($this->export, $this->log, $this->driver, $store, $request->getParam('type')))->__toString();

Expand Down
Loading