fix: respect Magento product list limit configuration#399
Open
woutk88 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module currently reads⚠️
product_list_limitdirectly from the request. Any value (including"all") is honored and can result in large result sets (up to 1000 items). This behavior can be abused by 🤖 bots or scripts to generate expensive requests, and we see crawlers requesting limits higher than those offered in the UIThe Magento pagination configuration should be respected and unsupported request limits should be rejected, including
"all"when it is not allowed. Default Magento validates the page size via its toolbar logic. This PR follows the same pagination limits.Not in this PR, but it would be a nice addition to also redirect URLs with invalid
product_list_limitvalues to the correct normalized URL.