feat: alp multi filter#58
Open
ahuininga-orisha wants to merge 12 commits into
Open
Conversation
jansentjeu
requested changes
May 8, 2026
jansentjeu
left a comment
Collaborator
There was a problem hiding this comment.
ALPs now also contain the configured filter as a query parameter. This was not the case previously.
added 2 commits
May 13, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Tweakwise Landing Page detection logic. Previously, if a user navigated to a category page and manually selected filters that matched a landing page's configuration (plus additional filters), the system failed to redirect/resolve to the specific Landing Page URL.
The logic has been updated to ensure that if a user is on a standard category page and selects all required filters for a Landing Page—even if additional filters (Filter Y) are active—the system will prioritize the Landing Page URL while retaining the supplemental filter parameters.
Additionally, this change addresses a bug in the
QueryParameterURL strategy where selecting multiple values for the same attribute resulted in duplicated filter parameters in the query string.Technical Changes
How to Test
Setup
Scenario 1: Redirection with Supplemental Filters
Scenario 2: Multi-value Duplicate Check (Query Parameter Strategy)
?filter_x=val1,val2or?filter_x=val1&filter_x=val2depending on config, but no redundant repetition of the same value).Scenario 3: Regression Testing