Skip to content

Fix: unserialize error #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahuininga-orisha wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: unserialize error #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9367c81
fix: unserialize error
May 13, 2026
9c458fd
Grumphp fixes
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/Model/LandingPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Magento\Framework\Model\AbstractExtensibleModel;
use Magento\Framework\Registry;
use Magento\Framework\Model\Context;
use Exception;
use Magento\Framework\Model\ResourceModel\AbstractResource;

/**
Expand Down Expand Up @@ -346,11 +347,22 @@ public function setFilterAttributes(?string $filterAttributes): LandingPageInter
*/
public function getUnserializedFilterAttributes(): array
{
if ($this->getFilterAttributes() === null) {
$raw = $this->getFilterAttributes();
if ($raw === null || $raw === '') {
return [];
}

return unserialize($this->getFilterAttributes());
try {
$result = unserialize($raw, ['allowed_classes' => false]);

@jansentjeu jansentjeu May 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely a class could never be stored here? This is data retrieved from the admin page's POST request.

@ahuininga-orisha ahuininga-orisha May 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the data originates from admin POST requests (so objects aren't expected), it's a security best practice — if the database row were ever tampered with, allowed_classes => false prevents PHP object injection attacks by making unserialize() throw instead of instantiating arbitrary classes.

} catch (Exception $e) {
return [];
}

if (!is_array($result)) {
return [];
}

return $result;
}

/**
Expand Down
9 changes: 8 additions & 1 deletion src/Model/UrlFinder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Emico\AttributeLanding\Api\Data\FilterInterface;
use Emico\AttributeLanding\Api\Data\LandingPageInterface;
use Emico\AttributeLanding\Api\LandingPageRepositoryInterface;
use Exception;
use Magento\Framework\Api\SearchCriteriaBuilder;
use Magento\Framework\App\CacheInterface;
use Magento\Framework\Serialize\SerializerInterface;
Expand Down Expand Up @@ -150,7 +151,13 @@ protected function loadPageLookupArray(): array

$landingPageLookup = [];
foreach ($this->landingPageRepository->getList($searchCriteria)->getItems() as $landingPage) {
$hash = $this->createHashForFilters($landingPage->getFilters(), $landingPage->getCategoryId());
try {
$filters = $landingPage->getFilters();
} catch (Exception $e) {
continue;
}

$hash = $this->createHashForFilters($filters, $landingPage->getCategoryId());
/** @phpstan-ignore-next-line */
$storeId = $landingPage->getData('store_id');
/** @phpstan-ignore-next-line */
Expand Down
Loading