Skip to content

Conversation

@ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Dec 23, 2025

While reruns are useful for mitigating flaky tests, a high rerun count significantly increases execution time for long-running integration tests (e.g. regtest / Docker-based setups). In the worst case, a single flaky test can run for nearly an hour, increasing the risk of GitHub Actions runner timeouts and unnecessary resource consumption.

Reducing the reruns to 4 provides a better balance by:

  • Limiting excessive re-execution of long-running tests
  • Reducing overall CI runtime and runner usage
  • Surfacing persistent or systemic issues earlier, rather than masking them with repeated retries

If a test consistently requires more than a few reruns to pass, it is likely indicative of a real issue rather than transient flakiness.

Changelog-None: CI enhancement only.

@ShahanaFarooqui ShahanaFarooqui added this to the v26.04 milestone Dec 23, 2025
…ource usage

While reruns are useful for mitigating flaky tests, a high rerun count significantly increases execution time for long-running integration tests (e.g. regtest / Docker-based setups). In the worst case, a single flaky test can run for nearly an hour, increasing the risk of GitHub Actions runner timeouts and unnecessary resource consumption.

Reducing the reruns to 4 provides a better balance by:
- Limiting excessive re-execution of long-running tests
- Reducing overall CI runtime and runner usage
- Surfacing persistent or systemic issues earlier, rather than masking them with repeated retries

If a test consistently requires more than a few reruns to pass, it is likely indicative of a real issue rather than transient flakiness.
@rustyrussell
Copy link
Contributor

See #8778

Much more comprehensive: I would rather add @flaky marks to tests once we know they are flaky.

@ShahanaFarooqui
Copy link
Collaborator Author

Closing this PR in favor of #8778.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants