Add IgnoreAbsentBattleAnimationFlash to Player config#3519
Open
ianling wants to merge 1 commit intoEasyRPG:masterfrom
Open
Add IgnoreAbsentBattleAnimationFlash to Player config#3519ianling wants to merge 1 commit intoEasyRPG:masterfrom
ianling wants to merge 1 commit intoEasyRPG:masterfrom
Conversation
Contributor
Author
|
Also open to naming the config option something else if you are interested; wasn't sure what to call it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is common for developers to use the
Flash Eventcommand rapidly in order to tint the player's sprite.If a developer uses the
Show Animationcommand at the same time, the animation will override the flash fromFlash Event, even if the animation does not contain any flashes. This behavior is present in both RPG Maker 2003 and EasyRPG.In my game for example, I am using Flash Event to darken the player sprite in a dark cave map. Also, when the player equips any item anywhere in the game, I play an animation using Show Animation. If the player equips an item in the cave map, despite the animation not containing any flashing, the Flash Event command appears to stop working for the duration of the animation. This causes the player sprite to appear untinted briefly.
This PR adds a new option to the Player config:
IgnoreAbsentBattleAnimationFlash(default: false -- retains prior behavior)When
true, battle animations that do not contain flashes will not override flashes from other sources, including Flash Event. Battle animations that do contain flashes still behave as before.If this isn't the kind of change you want to pull in, feel free to reject, I just needed this for my game and thought others might run into the same issue, as tinting the player is fairly common in Yume Nikki fan games.