Add decoder complexity for deep PLC#2
Merged
Conversation
DoumanAsh
reviewed
Sep 16, 2025
| ///Supported values are from 0 to 10, 10 meaning highest complexity. | ||
| ///Values of 5 or above will use deep packet loss concealment. | ||
| pub fn set_complexity(&mut self, value: u8) -> Result<(), ErrorCode> { | ||
| if value > 10 { |
Owner
There was a problem hiding this comment.
There is no need to duplicate this check, C code will validate it and return error just fine too
Contributor
Author
|
Not sure how you feel about the test I've added, even if the decoder complexity is set to 4 (and I suppose not using deep PLC), the output will still differ, so its more a test of the the complexity just affecting the decoded output. |
Owner
|
Test is sufficient on its own. After all change of output is tied to overall quality that opus sacrifices when you reduce complexity, and it is hardly possible to make a more complex test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2.
This adds the methods for the decoder complexity & two tests, gated behind the dred flag (since it by necessity includes the deep PLC resources), though you could optionally expose just the deep PLC build arg and these flags could be changed.