Add search for gpgv_binary common install paths if not found#512
Closed
Add search for gpgv_binary common install paths if not found#512
Conversation
emily-curry
previously approved these changes
Feb 6, 2026
another-yijiao
previously approved these changes
Feb 11, 2026
another-yijiao
left a comment
another-yijiao
left a comment
There was a problem hiding this comment.
could not reproduce the command -v gpgv failure scenario in testing but the changes make sense to me.
Piccirello
reviewed
Feb 11, 2026
scripts/install.sh
Outdated
| gpgv_binary="$(command -v gpgv || true)"; | ||
| # Fallback to common paths if command -v fails (e.g., in Docker builds where PATH isn't updated) | ||
| if [ ! -x "$gpgv_binary" ]; then | ||
| for path in /usr/bin/gpgv /bin/gpgv /usr/local/bin/gpgv; do |
Contributor
There was a problem hiding this comment.
Should this really be the responsibility of install.sh? /usr/bin, /bin, and/or /usr/local/bin should be added to the system's PATH, which command will then use.
amoses12
dismissed stale reviews from another-yijiao and emily-curry
via
a63b7c9
amoses12
force-pushed
the
austin/gnupg-path-update
branch
from
794a8a8 to
a63b7c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a search for the gpgv_binary install in common paths on linux systems before hitting the fallback logic. This is especially useful when installing in containers such as docker