grid: resolve intrinsic item percentages against the grid area#947
Open
gterzian wants to merge 2 commits into
Open
grid: resolve intrinsic item percentages against the grid area#947gterzian wants to merge 2 commits into
gterzian wants to merge 2 commits into
Conversation
Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com>
Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #920
Fixes the following WPT tests
Fail => Pass css/css-grid/alignment/grid-item-aspect-ratio-justify-self-001.html
Fail => Pass css/css-grid/alignment/grid-item-aspect-ratio-justify-self-002.html
Fail => Pass css/css-grid/grid-definition/flex-content-resolution-columns-001.html
Fail => Pass css/css-grid/grid-definition/flex-content-resolution-columns-002.html
Fail => Pass css/css-grid/grid-items/grid-item-containing-block-003.html
Fail => Pass css/css-grid/grid-items/grid-item-containing-block-004.html
Fail => Pass css/css-grid/grid-items/grid-items-percentage-margins-001.html
Fail => Pass css/css-grid/grid-items/grid-items-percentage-margins-002.html
Context
To make the WPT test pass in Servo required some changes there.
The screenshot still looks different from FF, but the WPT test is passing; I'm guessing because it's only the padding that matters.
Servo:
FF:
