Implement naive Position::Static#877
Open
nicoburns wants to merge 5 commits into
Open
Conversation
nicoburns
changed the title
Position::StaticPosition::Static
nicoburns
force-pushed
the
position-static
branch
from
bfe20da to
072e6f4
Compare
nicoburns
force-pushed
the
position-static
branch
from
072e6f4 to
3b8c5a1
Compare
nicoburns
force-pushed
the
position-static
branch
from
3b8c5a1 to
ea42fab
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
This allows us to land position:static without completing the implementation of fixed position (which we will land later).
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
position-static
branch
from
ea42fab to
5a546e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
An initial step in
position: staticsupport. This does not implement hoisting out-of-flow nodes (position:absoluteandposition:fixed) and positioning them relative to their non-direct-parent containing block. But it does implement ignoringinsetforposition:staticnodes and adds some helper methods which can be built upon when we do come to implement hoisting.