Skip to content

Fix opening native targets while they are still building and retry tcp connections to avoid server is still loading page#5358

Merged
ealmloff merged 4 commits into
DioxusLabs:mainfrom
ealmloff:fix-open-fullstack-build
Mar 13, 2026
Merged

Fix opening native targets while they are still building and retry tcp connections to avoid server is still loading page#5358
ealmloff merged 4 commits into
DioxusLabs:mainfrom
ealmloff:fix-open-fullstack-build

Conversation

@ealmloff
Copy link
Copy Markdown
Member

@ealmloff ealmloff commented Mar 10, 2026

Fixes two different issues:

  1. When you press "o" while the server/desktop app is still building, the cli crashes because the exe doesn't exist. The binary is already queued to open so we can just skip this
  2. There is a window between when the server has started and when it is reachable. We trigger the reload and proxy once the server starts, but if it isn't reachable, the connection fails. We can retry the tcp connection until we get a good connection and then use that connection to finish the request

Closes #5044
Closes #4981
Fixes #4082
Fixes #5021

@ealmloff ealmloff added the cli Related to the dioxus-cli program label Mar 10, 2026
@ealmloff ealmloff added the bug Something isn't working label Mar 10, 2026
@ealmloff ealmloff marked this pull request as ready for review March 10, 2026 21:53
@ealmloff ealmloff requested a review from a team as a code owner March 10, 2026 21:53
@ealmloff ealmloff merged commit 77a50f9 into DioxusLabs:main Mar 13, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli Related to the dioxus-cli program

Projects

None yet

2 participants