Open
Conversation
Member
JRS296
commented
Mar 26, 2026
JRS296
commented
- Removed Profile Dependency from Dataforge
- Added migration - Inclusion of support for profile ID to maintain GitHub Username (username) column
- Removed unused ProfileId based controller routes
- Removed unnecessary Health Endpoints
Member
Author
|
Resolves #52 |
| """Get all work experiences with locations by GitHub username""" | ||
| profile_service = ProfileService(self.session) | ||
| profile_id = profile_service.get_profile_id_by_github_username(github_username) | ||
| return self.get_work_experiences_by_profile_with_locations(profile_id) No newline at end of file |
Contributor
There was a problem hiding this comment.
This is a bit longwinded right? We should just keep user name in WorkEx, Education so on
Member
Author
There was a problem hiding this comment.
I don't get it. You mean it's unnecessray to have an endpoint to include complete location details of the work experience?
Comment on lines
-43
to
-51
| @router.get("/profile/{profile_id}", response_model=List[ReadWorkExperience]) | ||
| def get_work_experiences_by_profile_id(profile_id: UUID, session: Session = Depends(get_session)): | ||
| service = WorkExperienceService(session) | ||
| logger.info(f"Fetching Work Experiences for profile ID: {profile_id}") | ||
| work_experiences = service.get_work_experiences_by_profile_id(profile_id) | ||
| logger.info(f"Returned {len(work_experiences)} work experiences for profile {profile_id}") | ||
| return work_experiences | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Im assuming since there was no change in the path being called in the Dijkstra web PR that this API was never used?
Member
Author
There was a problem hiding this comment.
In an earlier version it was, but after we moved to TanStack, we moved to using GitHub Username as our primary means for calling the Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.