Skip to content

Windows: add guards for some methods that don't work/exist on windows #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tom-Willemsen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Windows: add guards for some methods that don't work/exist on windows #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ddca41
Windows: add guards for some methods that don't work/exist on win32
Tom-Willemsen Dec 19, 2025
ce40c51
Catch exception in non-console context rather than detecting pytest
Tom-Willemsen Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/fastcs/control_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import os
import signal
from collections.abc import Coroutine, Sequence
from functools import partial
Expand Down Expand Up @@ -45,8 +46,9 @@ def __init__(
def run(self, interactive: bool = True):
serve = asyncio.ensure_future(self.serve(interactive=interactive))

self._loop.add_signal_handler(signal.SIGINT, serve.cancel)
self._loop.add_signal_handler(signal.SIGTERM, serve.cancel)
if os.name != "nt":
self._loop.add_signal_handler(signal.SIGINT, serve.cancel)
self._loop.add_signal_handler(signal.SIGTERM, serve.cancel)
self._loop.run_until_complete(serve)

async def _run_initial_coros(self):
Expand Down
11 changes: 10 additions & 1 deletion src/fastcs/logging/_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import getpass
import os
import sys
from enum import StrEnum
from logging import LogRecord
from typing import TYPE_CHECKING, Any
Expand Down Expand Up @@ -30,8 +31,16 @@ def _configure_logger(
graylog_env_fields: GraylogEnvFields | None = None,
):
logger.remove()

try:
out = StdoutProxy(raw=True)
Copy link
Contributor

@GDYendell GDYendell Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer either stdout or sink for this variable name

except Exception:
# e.g. prompt_toolkit.output.win32.NoConsoleScreenBufferError on windows
# But it isn't exported from prompt_toolkit in a cross-platform way.
out = sys.stdout
Copy link
Contributor

@GDYendell GDYendell Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we log a warning that we are using raw stdout? I guess it will have to do it after the logger sink is added by isinstance checking the sink.


logger.add(
sink=StdoutProxy(raw=True), # type: ignore
sink=out, # type: ignore
colorize=True,
format=format_record,
level=level or "INFO",
Expand Down
Loading