B11: APR vs APY clarity#181
Open
cyberdocs120 wants to merge 1 commit into
Open
Conversation
… tests - Add .rate-convention-badge CSS (class was used but unstyled) - Add APY*/APY badges to hero Net APY, position Net APY, preview Est. net APY, vault Net APY, vault Supply APY, vault Borrow APY - APR grid rows (Interest APY, BLND APR, Net APY*) already had badges - Add docs/apr-vs-apy.md glossary with convention table and math - Add 18 unit tests in test/apr-apy-convention.test.ts covering: aprToApy formula, projectRates returns APR, display convention (interest→APY, BLND→APR), net APY* mixed convention, rate model sanity Closes Dgetsylver#38
|
@cyberdocs120 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Labels every user-facing rate with its compounding convention and locks in the chosen convention with unit tests.
Changes
frontend/index.html — Added
rate-convention-badgespans to all previously unlabeled rate displays: hero Net APY, position Net APY, preview Est. net APY, vault Net APY, vault Supply APY, vault Borrow APY. The APR grid rows (Interest APY, BLND APR, Net APY*) already had badges; the footnote was already present.frontend/src/style.css — Added
.rate-convention-badgestyle (the class was referenced in HTML but had no CSS definition).docs/apr-vs-apy.md — New glossary: APR/APY definitions, the
aprToApyformula, a table of every rate display location with its convention, and an explanation of the APY* mixed convention.frontend/test/apr-apy-convention.test.ts — 18 unit tests across 5 suites:
aprToApyformula,projectRatesreturns APR (pre-conversion), display convention (interest→APY, BLND→APR), net APY* mixed convention, rate model sanity. All pass.Convention
Acceptance criteria
Closes #38