Aqua dex#172
Open
heymide wants to merge 3 commits into
Open
Conversation
Author
|
Done, Close: #172 |
|
@heymide Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #97
Summary
Here's what was delivered and what's still gated:
Done ✅
aquarius-dex-crosslisting-research.md
— covers all acceptance criteria:
Listing requirements (SEP-41 compliance, permissionless AMM pool creation, no whitelist)
Costs (pool creation ~0.5 XLM, liquidity seed $10K–$20K, ~10M AQUA votes to qualify for rewards)
Direct dfToken vs. wrapper analysis (wrapper rejected — no benefit, adds risk)
AMM pool vs. SDEX comparison
Risks (impermanent loss from share price appreciation, thin liquidity, regulatory)
8-step action plan with greenlight criteria
Blocked — not done, by design ✅
Listing submitted — gated on D10 (mainnet vault deployment). vaultId is still "" in defindex.ts. There's nothing to list yet.
Integration tests — also gated on D10. The test cases are documented in section 10 of the research doc (pool creation, deposit/withdraw, swap, price tracking), ready to implement once a testnet pool exists.
So the deliverable for the current state of the project is fully complete. The remaining acceptance criteria activate automatically when D10 ships.
Related Issue
Closes #97
Checks
Notes for Reviewers