Feat/62 web push notifications#162
Open
elcabasa wants to merge 4 commits into
Open
Conversation
…e config to set envPrefix, and enhance alerts package.json with new build and migration scripts
…vements - Added new routes for web-push subscription management, including `/vapid-public-key` and `/push/subscribe`. - Implemented validation for alert targets to ensure correct pool IDs, asset symbols, and leverage brackets. - Updated email subscription handling to utilize the new validation function. - Modified frontend to support push notifications, including service worker registration and user permission requests. - Updated `wrangler.toml` to include VAPID keys for push notifications.
…ation - Enhanced web-push notification management with new routes for subscription. - Implemented validation for alert targets, ensuring accurate pool IDs and asset symbols. - Updated email subscription logic to incorporate new validation. - Modified frontend to support push notifications, including service worker registration. - Adjusted `wrangler.toml` to include necessary VAPID keys for push notifications.
Add setup:remote script, dev vars example, and gitignore for local secrets so web-push can be deployed after wrangler login. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@elcabasa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #62 — Progressive web-push APY alerts for connected wallets (no native app).
Issues #62
/sw.js) registered on app loadpush_subscriptions)Deploy notes (maintainer)
After merge:
cd alerts && npx wrangler login && npm run setup:remote(Set
RESEND_API_KEY/VAPID_PRIVATE_KEYsecrets; remote D1 migration.)Test plan
cd alerts && npm run buildcd frontend && npm install --ignore-scripts && npm run buildwrangler dev+ enable push in alert modal/vapid-public-keyreturns public key