Skip to content

Porf: modify URDF path handling: Pass from urdf_cfg to solver_cfg#135

Merged
chase6305 merged 4 commits intomainfrom
cjt/fix_urdf_path_pass
Feb 13, 2026
Merged

Porf: modify URDF path handling: Pass from urdf_cfg to solver_cfg#135
chase6305 merged 4 commits intomainfrom
cjt/fix_urdf_path_pass

Conversation

@chase6305
Copy link
Collaborator

Description

fix: #133

Checklist

  • I have run the black . command to format the code base.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Dependencies have been updated, if applicable.

@chase6305 chase6305 requested review from Copilot and yuecideng and removed request for Copilot February 13, 2026 06:43
@chase6305 chase6305 changed the title Porf: modify URDF path handling: Pass from urdf_cfg to solver_cfg" Porf: modify URDF path handling: Pass from urdf_cfg to solver_cfg Feb 13, 2026
Copilot AI review requested due to automatic review settings February 13, 2026 07:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #133 where PinkSolver fails when using the URDF assembly tool to build a robot from multiple components. The root cause is that when multiple URDF components are assembled, the assembled URDF path differs from the individual component paths, and solvers need to reference the assembled URDF path rather than the original component paths. This change automatically propagates the assembled URDF path from urdf_cfg to solver_cfg configurations when the solver's urdf_path is None.

Changes:

  • Automatically set solver_cfg.urdf_path to the assembled URDF path when it's None and urdf_cfg is used

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 13, 2026 07:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chase6305 chase6305 merged commit a323f8d into main Feb 13, 2026
11 checks passed
@chase6305 chase6305 deleted the cjt/fix_urdf_path_pass branch February 13, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] Pink Solver build fail with urdf composer

2 participants