Fix: Vitest, the "window.getComputedStyle" error is not defined when running tests #32062
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Vitest error that occurs when window.getComputedStyle is not defined during test execution. The fix adds defensive checking to prevent runtime errors in test environments where this browser API may not be available.
Key Changes:
- Added null check for
window.getComputedStylein thereadThemeMarkerfunction to return null gracefully when the API is unavailable - Added comprehensive test coverage for the error handling scenario with two test cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/themes.ts | Added defensive check to return null when window.getComputedStyle is undefined, preventing runtime errors |
| packages/devextreme/testing/tests/DevExpress.ui/themes.tests.js | Added new test module with two tests to verify proper handling when getComputedStyle is unavailable |
GoodDayForSurf
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.