fix(registry): drop suffix_match CALLS across language boundaries - #1647
fix(registry): drop suffix_match CALLS across language boundaries#1647rudi193-cmd wants to merge 1 commit into
Conversation
Two same-named symbols in different languages were collapsed by suffix_match onto one winner, so get_architecture hotspots inherited the other language's in-degree. unique_name (candidates==1) is DeusData#1572 and is left unchanged. JS/TS/TSX stay one family. Fixes DeusData#725 Signed-off-by: rudi193-cmd <rudi193@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thank you — and the scoping here is the part I want to call out. You fixed the cross-language case and explicitly left Treating JS/TS/TSX as one family is the detail most people would have missed. Dropping a Fair warning on timing: our CI is badly backed up tonight (8 runs queued, no runners allocating) because we are pushing a v0.10.5 that fixes a batch of install and startup blockers. Your PR is queued behind that. It is a graph-quality fix rather than an operability blocker, so it will land after the release rather than in it — no reflection on the change, just the order the queue forces. I will review it properly once the backlog clears. |
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Summary
suffix_matchno longer attaches CALLS (and therefore hotspotfan_in) to the wrong language.unique_name(candidates == 1) is left to Python stdlib import binds to a same-named TypeScript function (cross-language, strategy=unique_name) — poisons hotspots and Louvain clusters #1572. Receiver-type disambiguation among same-language candidates is Call resolution picks the wrong target (or none) for common method names in a Kotlin monorepo #1555..tscalling.tsxis not dropped.Test plan
scripts/test.sh --suites registry—cross_language_suffix_match_drops_py_vs_jsPASSscripts/test.sh --suites pipeline—pipeline_cross_language_same_name_does_not_share_calls_issue725PASS (251 passed)Made with Cursor