Skip to content

fix(mcp): release path filter on search launch failure - #1637

Open
ertankucukoglu wants to merge 1 commit into
DeusData:mainfrom
ertankucukoglu:fix/search-code-path-regex-cleanup
Open

fix(mcp): release path filter on search launch failure#1637
ertankucukoglu wants to merge 1 commit into
DeusData:mainfrom
ertankucukoglu:fix/search-code-path-regex-cleanup

Conversation

@ertankucukoglu

Copy link
Copy Markdown
Contributor

Summary

  • free the compiled search_code path_filter regex when the POSIX grep subprocess cannot be opened
  • keep the launch-failure cleanup path ownership-complete

This is the unrelated leak identified during review of #1608, split out as requested.

Testing

  • not run (small cleanup-only error-path change; CI will cover the normal search_code suite)

Signed-off-by: Ertan <ertan.kucukoglu@gmail.com>
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant