Relax ancestor ACL requirement for runtime dir (fixes #1621) - #1622
Open
Carnival-z wants to merge 1 commit into
Open
Relax ancestor ACL requirement for runtime dir (fixes #1621)#1622Carnival-z wants to merge 1 commit into
Carnival-z wants to merge 1 commit into
Conversation
Refactor posix_directory_parent_secure function to improve ACL handling for macOS.
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Allow ancestors (like /private/tmp on macOS) that carry allow-type ACLs so the daemon can create per-user runtime directories (/private/tmp/cbm-daemon-). The final runtime directory is still hardened: owner == current user, chmod 0700, and extended ACLs cleared.
Security: Only ancestor observation rules were relaxed for compatibility. Final runtime dir hardening (0700 + ACL clear) remains unchanged.
Testing suggestions:
macOS: verify daemon can create /private/tmp/cbm-daemon- when /private/tmp carries allow-ACLs; verify runtime dir is 0700 and ACLs cleared.
Ensure socket/lock/log files remain 0600 and ACLs cleared.
Fixes: #1621