perf(mcp): prefilter simple suffix globs on Windows - #1604
Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Could a maintainer please rerun the failed The run completed with 7465 passed tests and one failure in an unrelated timing-sensitive lock registry test:
This PR only changes Windows |
Signed-off-by: Ertan <ertan.kucukoglu@gmail.com>
829e1ff to
088b96b
Compare
|
Rebased onto current main and removed the unrelated comment rewrapping noted in review. The branch remains scoped to the results-preserving Windows suffix prefilter; the push also retriggers the previously flaky macOS LSan check. |
What does this PR do?
Prefilters safe simple suffix globs such as
*.pasand*.d.tsbefore PowerShellSelect-Stringon Windows.Complex patterns continue to use the existing post-filter path, and the final defensive file-pattern filter is preserved.
Adds regression coverage for safe/unsafe pattern boundaries and PowerShell command ordering.
Test results: 7353 passed, 0 failed, 63 skipped.
Part of #1565
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)