fix(ci): publish VT evidence under the marker the gate actually writes - #1603
Merged
Conversation
The v0.10.4 release (run 31755436916) failed at the very last step of `verify`, after all 69 other jobs had passed — full test matrix, all eight builds, smoke and soak: publish-vt-evidence: wrong evidence marker in binaries/vt-results.tsv The results format was bumped to `cbm-virustotal-results-v2` in #1596, but publish-vt-evidence.sh still demanded `-v1`. It was the only straggler: the gate, the selector, the notes renderer and all three contract fixtures were already on v2. It survived because that PR had removed the script's only caller, leaving it dead code that nothing exercised. Restoring the full-surface scan restored the caller too, and the stale expectation surfaced in the worst possible place — at the end of a real release rather than in a dry-run, since `verify` does not run in dry-runs. Also adds the guard that would have caught it: every marker publish-vt-evidence.sh validates must be one the gate actually writes. Revert-checked — reintroducing v1 fails with "publisher expects marker never written by the gate: cbm-virustotal-results-v1". The scan itself passed. This is purely the evidence-publishing step. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.10.4 release (run 31755436916) failed at the last step of
verify, after all 69 other jobs passed — the full test matrix, all eight builds, smoke and soak:#1596 bumped the results format to
cbm-virustotal-results-v2, butpublish-vt-evidence.shstill demanded-v1. It was the lone straggler —check-virustotal.sh,select-release-candidates.py,append-vt-notes.shand all three contract fixtures were already on v2.It survived review because #1596 had removed this script's only caller, so it sat as dead code nothing exercised. Restoring the full-surface post-package scan restored the caller, and the stale expectation surfaced at the end of a real release rather than in a dry-run —
verifydoes not run in dry-runs, which is exactly why this class needs a local guard.So this also adds one: every marker
publish-vt-evidence.shvalidates must be a marker the gate actually writes. Revert-checked — puttingv1back fails withpublisher expects marker never written by the gate: cbm-virustotal-results-v1.The VirusTotal scan itself passed; this is purely the evidence-publishing step.