security: record the mimalloc local patch in the vendored manifest - #1345
Merged
Conversation
The release build blocked at Layer 8 (vendored dependency integrity):
MISMATCH: vendored/mimalloc/src/options.c
expected: 96ef01e4...
actual: 192ce06a...
That is the integrity check working exactly as designed. The hardening pass
patched mimalloc's version banner to stop baking __DATE__/__TIME__ into every
binary, which is an intentional and reviewed change to vendored code -- but an
intentional change is indistinguishable from a supply-chain edit until someone
records it, which is the entire point of the manifest. Updating the recorded
checksum is the review being written down.
Scope verified before committing: the manifest diff is exactly ONE line, the
options.c hash, and it matches the hash CI computed. No other vendored file
moved. scripts/security-vendored.sh's other layers still pass on the updated
tree -- no subprocess, network or dangerous calls in vendored code, dlopen
confined to sqlite3.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Release run 30497863303 blocked at Layer 8 — Vendored Dependency Integrity:
This is the check working exactly as intended, and I should have anticipated it. #1344 patched mimalloc's version banner to stop baking
__DATE__/__TIME__into every binary (build-time entropy meant two builds of identical source could never share a hash). That edit is intentional and reviewed — but an intentional change to vendored code is indistinguishable from a supply-chain edit until someone records it, which is precisely what the manifest exists to force. Updating the checksum is the review being written down.Scope
The manifest diff is exactly one line — the
options.chash — and the new value matches the hash CI itself computed. No other vendored file moved.scripts/security-vendored.sh's remaining layers still pass on the updated tree: no subprocess/network/dangerous calls in vendored code,dlopenconfined to sqlite3, 75 files checked.Verification
The product code is unchanged from #1344, which was green on the full 3-OS local ladder: macOS 5166/0/0, Linux 6606/0/4 across 116 suites, Windows suites + guards green, macOS smoke
SMOKE_EXIT=0. This commit touches onlyscripts/vendored-checksums.txt.