feat(Attributes): Don't enforce Odin inspector#278
Open
jcs090218 wants to merge 1 commit intoDeadcows:masterfrom
Open
feat(Attributes): Don't enforce Odin inspector#278jcs090218 wants to merge 1 commit intoDeadcows:masterfrom
jcs090218 wants to merge 1 commit intoDeadcows:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think opening this kind of PR is a bit unusual. I’m currently using both Odin and MyBox, and I sometimes switch between them by simply changing the namespace. However, the preprocessor
#if ODIN_INSPECTORprevents that from working smoothly.I understand the author is trying to make it compatible with Odin, but I think it might be better to simply let users decide which one they want to use.