Use voxels to support 3d implicit plots#58
Draft
TendTo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have just found your gem of a library, and I was impressed by the work you have done.
When I was trying to plot the intersection of some 3 dimensional constrains,I noticed that the$f(x, y, z) = 0$ , which in my case would not suffice.
plot3d_implicithas some additional limitations when compared to the 2d version, in the fact that it plotsFor this reason, I experimented a bit with the backed to add naive support for arbitrary functions using the
voxelsfunction from k3d.The results are exactly what I was looking for, although I'm not sure they live up to the requirements you have set for your library.
I made this draft pr just to show you a working implementation of what I have done. Obviously you wold want to make quite a few changes if you were to implement it properly (e.g., Implicit3DSeriesVoxel should probably not inherit from Implicit3DSeries, if it is needed at all, and some stuff I just copied without understanding all the ramifications).
Thank you for your work!