Fixed critical velocity ratio#11
Merged
Merged
Conversation
Fixes Davide-sd#10 I used a different, but equivalent formula to the one proposed in the issue that also avoids division by zero at M = 0.
Owner
|
Thanks @aureliegrebe for the fix. I'm going to merge it, fix the tests and prepare a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #10
I used a different, but equivalent, formula to the one proposed by @hcliment that also avoids division by zero at M = 0.
Here is my working out:
Here is a comparison with the existing formula and the formula offered by @hcliment:
