feat(profiler)!: fork-safe managed exporter #1464
Open
+2,111
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsn
force-pushed
the
dsn/forksafe-exporter
branch
4 times, most recently
from
d4af4ba to
5d2c1cb
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 3244838 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
danielsn
force-pushed
the
dsn/forksafe-exporter
branch
from
5d2c1cb to
ec1141a
Compare
BenchmarksComparisonBenchmark execution time: 2026-01-22 14:54:46 Comparing candidate commit d91ac4e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
danielsn
force-pushed
the
dsn/forksafe-exporter
branch
2 times, most recently
from
da6f1e6 to
d91ac4e
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
danielsn
force-pushed
the
dsn/forksafe-exporter
branch
from
d91ac4e to
e1ea254
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1464 +/- ##
==========================================
+ Coverage 71.16% 71.46% +0.29%
==========================================
Files 419 420 +1
Lines 67165 67965 +800
==========================================
+ Hits 47795 48568 +773
- Misses 19370 19397 +27
🚀 New features to boost your workflow:
|
danielsn
changed the title
danielsn
force-pushed
the
dsn/forksafe-exporter
branch
from
e1ea254 to
3244838
Compare
danielsn
changed the title
| let cloned_receiver: Receiver<RequestBuilder> = receiver.clone(); | ||
| let cloned_cancel = cancel.clone(); | ||
| let handle = std::thread::spawn(move || { | ||
| let runtime = tokio::runtime::Builder::new_current_thread() |
Contributor
There was a problem hiding this comment.
Any reason for not using a multi threaded runtime with a single thread ?
Contributor
Author
There was a problem hiding this comment.
The multi-threaded runtime adds more complexity that we don't need if we're single threaded, afaict?
| @@ -0,0 +1,573 @@ | |||
| // Copyright 2021-Present Datadog, Inc. https://www.datadoghq.com/ | |||
Contributor
There was a problem hiding this comment.
fyi we did something similar in libdd-data-pipeline/src/pausable_worker.rs
| receiver: Receiver<RequestBuilder>, | ||
| } | ||
|
|
||
| pub struct SuspendedExporterManager { |
Contributor
There was a problem hiding this comment.
Would it make sense to handle the state management in rust with an enum ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a forksafe exporter where the rust side manages all state.
Motivation
We've had recurrent bugs in Python when it comes to forksafety of code like this. Having a simple API is great.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
See the new tests and the example files.