RUM-8042 Batch Blocked telemetry with generic aggregation#2230
Draft
RUM-8042 Batch Blocked telemetry with generic aggregation#2230
Conversation
229b5b9 to
09a608a
Compare
Datadog ReportBranch report: ✅ 0 Failed, 2423 Passed, 1485 Skipped, 3m 5.28s Total duration (1m 11.75s time saved) |
09a608a to
f51cb4c
Compare
barboraplasovska
previously approved these changes
Mar 13, 2025
5204914
aa1b8d9 to
31ae520
Compare
jonathanmos
reviewed
Mar 17, 2025
mariedm
reviewed
Mar 17, 2025
Member
mariedm
left a comment
There was a problem hiding this comment.
Just a couple of small questions, otherwise LGMT!
Valpertui
previously approved these changes
Mar 17, 2025
31ae520 to
564152b
Compare
de4fe5a to
0b556f7
Compare
cd68fed to
04e471b
Compare
4f1d95b to
2cab83e
Compare
5d65982 to
6dc667f
Compare
6dc667f to
f4df695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Introduce a new telemetry metric for tracking batch upload issues. It replaces the previous "Upload Quality" telemetry with a more specific "Batch Blocked" metric that provides better visibility into upload failures. This change provides a telemetry format more suitable for graphing.
More context in RFC (internal)
How?
The implementation uses a generic metric telemetry aggregation to collect metric and report them when the application is pushed to background:
1. Metric Types:
2. Metrics:
batch_blocked: Tracks the number of times batch uploads are blockedpending_batches: Tracks the number of batches waiting to be uploadedupload_cycle: Monitors count of upload cycleEach metric supports configurable cardinalities for detailed analysis
4. Architecture:
Review checklist
make api-surface)