[RUM-6573] add optional build_id parameter for Android mapping uploads#2090
[RUM-6573] add optional build_id parameter for Android mapping uploads#2090kyletaylored wants to merge 1 commit intoDataDog:masterfrom
Conversation
When --build-id is provided for Android mapping files, service name, version, and variant are no longer required. This aligns with the native Android gradle task behavior where build_id overrides other metadata fields. Relates to DataDog#1477
|
@kyletaylored We should touch base on this, since Flutter doesn't actually support build_id (yet) it's weird to add it to the Instead, we may just want to take the step suggested in #1477 and add a manual android symbols upload command, then have Let me know what you think. |
|
Heya! So what I learned tracking this down is that even though it's for the
So really all this PR does is if the Flutter build is generating an Android app, we can push that And it looks like there was a closed issue in the |
evazorro
left a comment
There was a problem hiding this comment.
Approving the README update on behalf of the Docs team!
When --build-id is provided for Android mapping files, service name, version, and variant are no longer required. This aligns with the native Android gradle task behavior where build_id overrides other metadata fields.
Relates to #1477
What and why?
Adds an optional
--build-idparameter to theflutter-symbols uploadcommand for Android mapping files. When provided,build_idoverrides the requirement for--service-name,--version, and--flavor, aligning the Flutter CLI behavior with the native Android Gradle task where build_id is the primary identifier.How?
--build-idCLI option to FlutterSymbolsUploadCommandbuild_idfield and madeservice,version, andvariantoptionalgetMappingMetadata()to conditionally includebuild_idORservice/version/variantbased on whether build_id is providedverifyParameters()to skip service name and version requirements when--build-idis provided with Android mappingReview checklist