Models view dont wait for backend data to show the page.#525
Merged
cristian-tamblay merged 3 commits intodevelopfrom Apr 8, 2026
Merged
Models view dont wait for backend data to show the page.#525cristian-tamblay merged 3 commits intodevelopfrom
cristian-tamblay merged 3 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves perceived responsiveness in the Models section by introducing a task-level loading state and showing skeleton placeholders while tasks are fetched, instead of blocking the entire page behind a fullscreen spinner.
Changes:
- Added a
loadingTasksstate to the modelsuseSessionshook and propagated it throughModelsContext. - Updated
SelectOptionMenuto accept aloadingprop and render skeleton cards when loading. - Removed the initial fullscreen loading spinner from
ModelsContentand switched to non-blocking initial fetch calls.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DashAI/front/src/pages/models/ModelsContent.jsx | Removes initial fullscreen spinner and triggers initial fetches on mount. |
| DashAI/front/src/hooks/models/useSessions.js | Introduces loadingTasks state toggled during fetchTasks(). |
| DashAI/front/src/components/threeSectionLayout/SelectOptionMenu.jsx | Adds loading prop and skeleton-card rendering for loading state. |
| DashAI/front/src/components/models/ModelsContext.jsx | Exposes loadingTasks via Models context provider. |
| DashAI/front/src/components/models/ModelCenterContent.jsx | Passes loadingTasks to SelectOptionMenu for task selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…on dataloaders, to delete the dir after use
cristian-tamblay
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience when loading tasks in the models section by introducing a loading state and skeleton placeholders. Instead of blocking the entire page with a spinner, the UI now displays skeleton cards while tasks are being fetched, making the interface feel more responsive and polished. The loading state is managed via a new
loadingTasksvariable, which is propagated through context and component props.Loading state management and UI improvements:
loadingTasksstate to theuseSessionshook, set totruewhile tasks are being fetched andfalseonce loading completes. This state is now included in the context and passed down to relevant components. [1] [2] [3] [4] [5] [6] [7]SelectOptionMenuto accept aloadingprop and render six skeleton cards in place of options when loading istrue, providing a smoother and more modern loading experience. [1] [2] [3] [4]Simplification of initial loading logic:
ModelsContent.jsx. The initial data fetching is now handled without blocking the entire page, relying on the new skeleton-based loading indicators for tasks. [1] [2] [3] [4]