Open
Conversation
Add a generic implementation of CMAC using a BlockEncryptor. Tested only against AES128, AES192 and AES256.
|
Any chance this will be merged to master soon? |
|
@DaGenix is anything besides the failing build preventing this from being merged? |
|
@flybayer last commit was merged 7 month ago. It smells like a dead repo. I thought about making one small PR, but now I have doubts... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around with CMAC and I thought I'd contribute back what code I have.
I'm still learning rust, so the code is by no means perfect. Also, given the lack of documentation there was a bit of guesswork to find things that were already implemented.
A couple of possible (but for me tricky) improvements are: