Conversation
|
|
||
| ## diracx release | ||
|
|
||
| [PROCESS TO BE COMPLETED BY ALEXANDRE] |
chaen
force-pushed
the
doc_makereleases
branch
2 times, most recently
from
ee1197a to
4f0fa1d
Compare
chaen
force-pushed
the
doc_makereleases
branch
from
4f0fa1d to
75c0a2a
Compare
Expand paths-ignore in main, integration, and deployment workflows to cover all Markdown files, the docs directory, and mkdocs.yml. This avoids running expensive integration tests when only documentation is modified.
| === "Gitlab" | ||
|
|
||
| This assumes you are |
There was a problem hiding this comment.
Is that expected?
| === "Gitlab" | |
| This assumes you are |
| diracx -->|renovate| extension | ||
| diracx-web -->|renovate| extension-web | ||
| extension -->|commit and bump diracx-charts| extension-charts | ||
| extension-web -->|commit| extension-charts |
There was a problem hiding this comment.
Shouldn't we also bump extension-charts if we update extension-web?
| extension-web -->|commit| extension-charts | |
| extension-web -->|commit and bump diracx-charts| extension-charts |
| diracx -->|commit| diracx-charts | ||
| diracx-web -->|commit| diracx-charts |
There was a problem hiding this comment.
Same here?
| diracx -->|commit| diracx-charts | |
| diracx-web -->|commit| diracx-charts | |
| diracx -->|commit and bump diracx-charts| diracx-charts | |
| diracx-web -->|commit and bump diracx-charts| diracx-charts |
| git push upstream HEAD:main | ||
| ``` | ||
|
|
||
| - TODO: update the release notes manually |
There was a problem hiding this comment.
Is that for another PR? Shall I create an issue for that?
| ```mermaid | ||
| flowchart LR | ||
| subgraph diracx-block["diracx"] | ||
| diracx-charts("diracx-charts") | ||
| diracx("diracx") | ||
| diracx-web("diracx-web") | ||
| end | ||
|
|
||
|
|
||
| diracx -->|commit| diracx-charts | ||
| diracx-web -->|commit| diracx-charts | ||
|
|
||
| linkStyle 0 stroke: blue | ||
| linkStyle 1 stroke: blue | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Don't you want to also include DIRAC and DIRACCommon in this diagram?
Else, it looks like it could be moved to Dependencies between diracx, diracx-web and diracx-charts.
|
|
||
| - the chart version | ||
| - the container versions | ||
| - NOT the AppVersion |
There was a problem hiding this comment.
I am not sure to understand why there is a difference between diracx and diracx-web here.
Can you may be add a comment on that please?
|
|
||
| ## diracx release | ||
|
|
||
| Releases are managed by `ReleasePlease`. The token used to perform it belongs to `diracbot` github user |
There was a problem hiding this comment.
Shall we document diracx-web release here? I think yes.
It would be very similar to diracx release.
The only differences are:
- we are not using
diracbotbecause we don't need it (at least for now) pypi releasebecomesnpm releasefordiracx-web-components. See https://www.npmjs.com/package/@dirac-grid/diracx-web-components
There was a problem hiding this comment.
Isn't it "DIRACGridBot" instead of "diracbot"?
| ```bash | ||
| git commit --allow-empty -m "chore: release 0.0.3" -m "Release-As: v0.0.3" | ||
| git push upstream HEAD:main | ||
| ``` |
There was a problem hiding this comment.
This is also written in make-a-release.md. Shouldn't we add a reference to it here?
|
|
||
| DiracX should be upgraded before upgrading legacy DIRAC installations. | ||
|
|
||
| The versioning of `DIRAC`, `DIRACCommon`, `diracx`, `diracx-charts` and all the extensions are very linked to one another. |
There was a problem hiding this comment.
| The versioning of `DIRAC`, `DIRACCommon`, `diracx`, `diracx-charts` and all the extensions are very linked to one another. | |
| The versioning of `DIRAC`, `DIRACCommon`, `diracx`, `diracx-charts` and all the extensions are linked to one another. |
| - the AppVersion | ||
| - the container versions | ||
|
|
||
| The `update-charts` CI job in `diracx` pushes a new commit in `diracx-charts`, which results in a new `diracx-charts` release. |
|
|
||
| ## diracx release | ||
|
|
||
| Releases are managed by `ReleasePlease`. The token used to perform it belongs to `diracbot` github user |
There was a problem hiding this comment.
Isn't it "DIRACGridBot" instead of "diracbot"?
| @@ -0,0 +1,46 @@ | |||
| This page describes how to mechanically make releases of DiracX and extensions. See the [reference](../reference/making-releases.md) documentation for more details about how releases are made. | |||
There was a problem hiding this comment.
Add a note to follow this in the presented order.
|
|
||
| - TODO: update the release notes manually | ||
|
|
||
| 4. Merge the PR |
There was a problem hiding this comment.
| 4. Merge the PR | |
| 4. Merge the `release-please` PR |
|
|
||
| # How to make a new DiracX release | ||
|
|
||
| 1. Merge any PR you want in your release |
There was a problem hiding this comment.
Remove this step, it's done asynchronously.
| 3. Create tag (and optionally [release](<>)) for your extension | ||
| 4. Updates to extension's "charts" repo will be pushed automatically or via merge requests depending on your setup. | ||
|
|
||
| === "LHCb" |
There was a problem hiding this comment.
I would put this in a wiki/note/whatever
4 participants
No description provided.