suppress warning for 'protocols' field from externalWritersToShm()#220
Open
m1tk4 wants to merge 1 commit intoDDVTECH:developmentfrom
Open
suppress warning for 'protocols' field from externalWritersToShm()#220m1tk4 wants to merge 1 commit intoDDVTECH:developmentfrom
m1tk4 wants to merge 1 commit intoDDVTECH:developmentfrom
Conversation
…RAX_NESTED can be empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suppresses a confusing warning "Attempting to add a mandatory-size field without size" that is caused by externalWritersToShm() processing an empty external writers list.
Assumption is made that 0 is a valid size for RAX_NESTED field than may be an empty object.
Added logging the field name in case this warning does show up for legitimate reasons.