Skip to content

chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitarrapc merged 2 commits into from
Sep 24, 2025
Merged

chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8544db1
chore: Specify IsPackable=false on Directory.Build.props, explicitly …
guitarrapc Sep 24, 2025
03f41ee
chore: update MemoryPack to latest
guitarrapc Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,19 @@ publish
*.Publish.xml

# NuGet Packages Directory
packages
*.nupkg
# NuGet Symbol Packages
*.snupkg
# The packages folder can be ignored because of Package Restore
# packages # upm pacakge will use Packages
**/[Pp]ackages/*
# except build/, which is used as an MSBuild target.
!**/[Pp]ackages/build/
# Uncomment if necessary however generally it will be regenerated when needed
#!**/[Pp]ackages/repositories.config
# NuGet v3's project.json files produces more ignorable files
*.nuget.props
*.nuget.targets

# Windows Azure Build Output
csx
Expand Down Expand Up @@ -107,9 +119,6 @@ UpgradeLog*.XML
.vs/config/applicationhost.config
.vs/restore.dg

nuget/tools/*
nuget/*.nupkg
nuget/*.unitypackage
.vs/

# Jetbrains Rider
Expand Down
3 changes: 3 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<NoWarn>$(NoWarn);CS1591</NoWarn>

<!-- NuGet Packaging -->
<IsPackable>false</IsPackable>
<PackageVersion>$(Version)</PackageVersion>
<Company>Cysharp</Company>
<Authors>Cysharp</Authors>
Expand All @@ -21,6 +22,8 @@
</PropertyGroup>

<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)Icon.png" Pack="true" PackagePath="\" />
<None Include="$(MSBuildThisFileDirectory)README.md" Pack="true" PackagePath="\" />
<EmbeddedResource Include="$(MSBuildThisFileDirectory)LICENSE" />
</ItemGroup>
</Project>
0 src/MessagePipe.Analyzer/Icon.png → Icon.png
View file
Open in desktop
File renamed without changes
1 change: 0 additions & 1 deletion sandbox/InterprocessServer/InterprocessServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/MessagePipe.AnalyzerTestApp/MessagePipe.AnalyzerTestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion sandbox/MessagePipe.Sandbox.ConsoleApp/MessagePipe.Sandbox.ConsoleApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<TargetFramework>net6.0</TargetFramework>
<Configurations>Debug;Release;WinBenchmark</Configurations>
<SignAssembly>true</SignAssembly>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
Expand Down
56 changes: 26 additions & 30 deletions src/MessagePipe.Analyzer/MessagePipe.Analyzer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,33 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>library</OutputType>
<TargetFramework>netstandard2.0</TargetFramework>
<IsRoslynComponent>true</IsRoslynComponent>
<TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);PackBuildOutputs</TargetsForTfmSpecificContentInPackage>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IncludeSymbols>false</IncludeSymbols>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<DevelopmentDependency>true</DevelopmentDependency>
<PropertyGroup>
<OutputType>library</OutputType>
<TargetFramework>netstandard2.0</TargetFramework>
<IsRoslynComponent>true</IsRoslynComponent>
<TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);PackBuildOutputs</TargetsForTfmSpecificContentInPackage>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IncludeSymbols>false</IncludeSymbols>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<DevelopmentDependency>true</DevelopmentDependency>

<!-- NuGet Packaging -->
<PackageTags>analyzer;</PackageTags>
<Description>Analyzers of MessagePipe to prevent subscription leak.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>
<!-- NuGet Packaging -->
<PackageTags>analyzer;</PackageTags>
<Description>Analyzers of MessagePipe to prevent subscription leak.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.3">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.1.0" />
</ItemGroup>

<Target Name="PackBuildOutputs" DependsOnTargets="SatelliteDllsProjectOutputGroup;DebugSymbolsProjectOutputGroup">
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.3">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.1.0" />
<TfmSpecificPackageFile Include="$(TargetDir)\*.dll" PackagePath="analyzers\dotnet\cs" />
<TfmSpecificPackageFile Include="@(SatelliteDllsProjectOutputGroupOutput->'%(FinalOutputPath)')" PackagePath="analyzers\dotnet\cs\%(SatelliteDllsProjectOutputGroupOutput.Culture)\" />
</ItemGroup>

<Target Name="PackBuildOutputs" DependsOnTargets="SatelliteDllsProjectOutputGroup;DebugSymbolsProjectOutputGroup">
<ItemGroup>
<TfmSpecificPackageFile Include="$(TargetDir)\*.dll" PackagePath="analyzers\dotnet\cs" />
<TfmSpecificPackageFile Include="@(SatelliteDllsProjectOutputGroupOutput->'%(FinalOutputPath)')" PackagePath="analyzers\dotnet\cs\%(SatelliteDllsProjectOutputGroupOutput.Culture)\" />
</ItemGroup>
</Target>
</Target>
</Project>
Binary file removed src/MessagePipe.Interprocess/Icon.png
View file
Open in desktop
Binary file not shown.
78 changes: 37 additions & 41 deletions src/MessagePipe.Interprocess/MessagePipe.Interprocess.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,41 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<WarningsAsErrors>true</WarningsAsErrors>
<Configurations>Debug;Release;</Configurations>

<!-- NuGet Packaging -->
<PackageTags>pubsub;eventaggregator</PackageTags>
<Description>Interprocess extensions for MessagePipe.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="MessagePack" Version="2.3.85" />
<PackageReference Include="System.IO.Pipelines" Version="6.0.3" />
<ProjectReference Include="..\MessagePipe\MessagePipe.csproj" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework) == 'netstandard2.0'">
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageReference Include="System.Threading.Channels" Version="6.0.0" />
</ItemGroup>

<!-- Copy files for Unity -->
<PropertyGroup>
<DestinationRoot>$(MSBuildProjectDirectory)\..\MessagePipe.Unity\Assets\Plugins\MessagePipe.Interprocess\Runtime\</DestinationRoot>
</PropertyGroup>
<ItemGroup>
<TargetFiles1 Include="$(MSBuildProjectDirectory)\**\*.cs" Exclude="**\bin\**\*.*;**\obj\**\*.*;_InternalVisibleTo.cs" />
</ItemGroup>

<Target Name="PostBuild" AfterTargets="PostBuildEvent">
<Copy SourceFiles="@(TargetFiles1)" DestinationFiles="$(DestinationRoot)\%(RecursiveDir)%(Filename)%(Extension)" SkipUnchangedFiles="true" />

<!-- After copy, replace for unity codes -->
<Exec Command="dotnet run --no-build -c $(ConfigurationName) --project $(MSBuildProjectDirectory)\..\..\tools\PostBuildUtility\PostBuildUtility.csproj -- replace-to-unity $(DestinationRoot)" />
</Target>
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<WarningsAsErrors>true</WarningsAsErrors>
<Configurations>Debug;Release;</Configurations>

<!-- NuGet Packaging -->
<PackageTags>pubsub;eventaggregator</PackageTags>
<Description>Interprocess extensions for MessagePipe.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="MessagePack" Version="3.1.4" />
<PackageReference Include="System.IO.Pipelines" Version="6.0.3" />
<ProjectReference Include="..\MessagePipe\MessagePipe.csproj" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework) == 'netstandard2.0'">
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageReference Include="System.Threading.Channels" Version="6.0.0" />
</ItemGroup>

<!-- Copy files for Unity -->
<PropertyGroup>
<DestinationRoot>$(MSBuildProjectDirectory)\..\MessagePipe.Unity\Assets\Plugins\MessagePipe.Interprocess\Runtime\</DestinationRoot>
</PropertyGroup>
<ItemGroup>
<TargetFiles1 Include="$(MSBuildProjectDirectory)\**\*.cs" Exclude="**\bin\**\*.*;**\obj\**\*.*;_InternalVisibleTo.cs" />
</ItemGroup>

<Target Name="PostBuild" AfterTargets="PostBuildEvent">
<Copy SourceFiles="@(TargetFiles1)" DestinationFiles="$(DestinationRoot)\%(RecursiveDir)%(Filename)%(Extension)" SkipUnchangedFiles="true" />

<!-- After copy, replace for unity codes -->
<Exec Command="dotnet run --no-build -c $(ConfigurationName) --project $(MSBuildProjectDirectory)\..\..\tools\PostBuildUtility\PostBuildUtility.csproj -- replace-to-unity $(DestinationRoot)" />
</Target>

</Project>
Binary file removed src/MessagePipe.Nats/Icon.png
View file
Open in desktop
Binary file not shown.
40 changes: 20 additions & 20 deletions src/MessagePipe.Nats/MessagePipe.Nats.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<!-- NuGet Packaging -->
<PackageTags>pubsub;eventaggregator</PackageTags>
<Description>Nats IDistributedPublisher/Subscriber provider for MessagePipe.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>
<!-- NuGet Packaging -->
<PackageTags>pubsub;eventaggregator</PackageTags>
<Description>Nats IDistributedPublisher/Subscriber provider for MessagePipe.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>
<ItemGroup>
<None Include="Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="AlterNats" Version="1.0.0" />
<PackageReference Include="MessagePack" Version="2.3.85" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AlterNats" Version="1.0.0" />
<PackageReference Include="MessagePack" Version="3.1.4" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\MessagePipe\MessagePipe.csproj" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\MessagePipe\MessagePipe.csproj" />
</ItemGroup>

</Project>
Binary file removed src/MessagePipe.Redis/Icon.png
View file
Open in desktop
Binary file not shown.
38 changes: 19 additions & 19 deletions src/MessagePipe.Redis/MessagePipe.Redis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<Configurations>Debug;Release;WinBenchmark</Configurations>
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<Configurations>Debug;Release;WinBenchmark</Configurations>

<!-- NuGet Packaging -->
<PackageTags>pubsub;eventaggregator</PackageTags>
<Description>Redis IDistributedPublisher/Subscriber provider for MessagePipe.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>
<!-- NuGet Packaging -->
<PackageTags>pubsub;eventaggregator</PackageTags>
<Description>Redis IDistributedPublisher/Subscriber provider for MessagePipe.</Description>
<SignAssembly>true</SignAssembly>
<IsPackable>true</IsPackable>
</PropertyGroup>

<ItemGroup>
<None Include="Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>
<ItemGroup>
<None Include="Icon.png" Pack="true" PackagePath="/" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="MessagePack" Version="2.3.85" />
<PackageReference Include="StackExchange.Redis" Version="2.5.61" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="MessagePack" Version="3.1.4" />
<PackageReference Include="StackExchange.Redis" Version="2.5.61" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\MessagePipe\MessagePipe.csproj" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\MessagePipe\MessagePipe.csproj" />
</ItemGroup>

</Project>
Binary file removed src/MessagePipe/Icon.png
View file
Open in desktop
Binary file not shown.
Loading
Loading