implem GCP Storage connector#28
Merged
Merged
Conversation
amanteaux
requested changes
Oct 29, 2025
| public void deleteAll(List<String> fileUniqueNames) throws IOException { | ||
| for (String fileUniqueName : fileUniqueNames) { | ||
| BlobId blobId = BlobId.of(bucketName, objectName(fileUniqueName)); | ||
| if (!storage.delete(blobId)) { |
Member
There was a problem hiding this comment.
J'ai l'impression que la spec n'est pas respectée :
* Delete the files data identified by the fileUniqueNames.
* If a file is already deleted, no exception must be raised
* Must not fail if the files have already been deleted
Member
Author
There was a problem hiding this comment.
ha yes tu as raison :/
on a aussi le cas sur FileStorageDatabaseService
amanteaux
requested changes
Oct 30, 2025
| public void deleteAll(List<String> fileUniqueNames) { | ||
| for (String fileUniqueName : fileUniqueNames) { | ||
| BlobId blobId = BlobId.of(bucketName, objectName(fileUniqueName)); | ||
| storage.delete(blobId); |
Member
There was a problem hiding this comment.
ça va pas faire une exception si le blobID est null ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.