fix(#175): clear notification feed immediately on wallet switch - #334
Merged
Abd-Standard merged 1 commit intoJun 26, 2026
Merged
Conversation
…switch Root cause: EventExplorerPage and ActivityFeed fetched data once on mount with no subscription to walletStore.address. Switching wallets updated the store but neither component reacted, leaving stale events on screen. Changes: - Add useWalletAccountSync hook — fires a callback on every subsequent address change (wallet switch or disconnect), skipping the initial mount. Callback ref is stable so callers can pass inline functions without causing spurious re-subscriptions. - EventExplorerPage: wire in useWalletAccountSync to clear the event store, reset to page 1, and re-fetch on account change. Also remove duplicate fetchEvents import and duplicate loadEvents() call that were causing double fetches on every mount. - ActivityFeed: wire in useWalletAccountSync to clear local events, live events, and total count, reset to page 1, and reload on account change. - wallet-integration.test.tsx: add four regression tests under 'Notification feed clears on wallet switch (issue Core-Foundry#175)' covering immediate address update on switch, null address after disconnect, no stale localStorage after switch, and all three supported wallet providers.
|
@Jessepriase Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: EventExplorerPage and ActivityFeed fetched data once on mount with no subscription to walletStore.address. Switching wallets updated the store but neither component reacted, leaving stale events on screen.
Changes:
closes [Bug] Notification Feed Fails to Update After Wallet Switch #175