test: add TestConcoredockerApi covering read/write/unchanged/initVal#490
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
test: add TestConcoredockerApi covering read/write/unchanged/initVal#490avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
@pradeeban TestConcoredockerApi: 20/20 TestLiteralEval: 50/50
|
Author
|
Hey @pradeeban Pls take a look, and one thing worth noting, setDelay(0) in the test runner is necessary, otherwise each read() blocks for 1s and the suite takes around 6s for nothing. let me know if you'd prefer a different approach there. Took a bit longer than expected since I wanted to make sure the temp dir setup was clean and didn't bleed state between tests, resetState() handles that :p |
Author
|
@pradeeban also Python ZMQ uses send_json/recv_json but Java sends Python literals.... True/None will break json.loads on the Python side. worth aligning? for Java I think, just want to make sure its a ryt direction :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


closes #464
Added TestConcoredockerApi.java... real file I/O tests for read(), write(), unchanged(), initVal() using temp dirs.
Had to add 5 package-level setters to concoredocker.java (setInPath, setOutPath, setDelay, getSimtime, resetState) so tests can wire up without touching /in /out.
Builds on top of #468 (methods are now public).