feat: add shared memory transport to concoredocker.hpp (#486)#487
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
feat: add shared memory transport to concoredocker.hpp (#486)#487avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban Looked at this the SHM logic in concore.hpp maps over cleanly. kept it minimal :D |
avinxshKD
force-pushed
the
feat/shm-concoredocker
branch
2 times, most recently
from
a72e309 to
b66aadf
Compare
avinxshKD
force-pushed
the
feat/shm-concoredocker
branch
from
b66aadf to
7e8090e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concore.hpp has had SHM transport for a while. concoredocker.hpp never got it ....only file and ZMQ. Docker on Linux supports --ipc=host just fine, so there's no reason it should stay crippled.
Ported the whole thing over: private members, ExtractNumeric, createSharedMemory/getSharedMemory, read_SM/write_SM, destructor cleanup, move semantics, and dispatch routing in read()/write().
Closes #486