test: add Concore class API tests for concore.hpp #485
Open
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Open
test: add Concore class API tests for concore.hpp #485avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
Hey @pradeeban @Rahuljagwani @mayureshkothare While building out the transport layer in the julia prototype, I ran into a performance question worth flagging With file I/O, even delay=0 still hits disk on every poll (open + read + close per call). For co-located nodes, Mmap.jl would keep reads in memory -- same polling loop, no syscall overhead, so the delay can be pushed much lower without thrashing I/O. Planning to measure this properly: file vs mmap vs ZMQ, same study, same workload. The benchmark results and methodology could double as a short research note if that's useful for the project. Any suggestions :p Also should the mmap backend be opt-in at init, or would automatic detection of co-located nodes be worth the complexity? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added TestConcoreHpp.cpp following the same custom pass/fail pattern. Sets up temp port dirs, does real file read/write round-trips, tests unchanged() state transitions, retry exhaustion on empty files, and param loading. No gtest.
closes #484