fix(readiness): restack immutable evidence toolchain after commercial writer - #218
Merged
seonghobae merged 2 commits intoAug 12, 2026
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughreadiness-scan 워크플로의 액션, Node.js, npm 설정을 고정했습니다. 아티팩트 누락 시 업로드가 실패하도록 변경했습니다. 새 Vitest 테스트가 이 설정을 검증합니다. ChangesReadiness 워크플로 무결성
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 12, 2026 10:08
seonghobae
deleted the
fix/readiness-scan-immutable-toolchain-current-main-v2
branch
August 12, 2026 10:12
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fresh protected-main successor for #145 / historical readiness-toolchain work after the commercial-writer integration. This branch is based directly on protected
main2b3eee922efaa7ae2f11040b1a82a2ce305b75c6; no predecessor checks, reviews, scanner/model evidence, production evidence, or merge authority transfer.Test-first lineage
3fccc27b192b67f6e45aaf15122db8e532347a20added onlytest/readiness-scan-toolchain-integrity.test.tsand reproduced the protected readiness-workflow defects.1bf9eb8036669939e9a8f0d759571c81ce5b685achanges only.github/workflows/readiness-scan.ymlplus that regression test.The bounded GREEN pins the reviewed checkout/setup-node/upload-artifact revisions, disables persisted checkout credentials, binds Node
24.19.0and npm11.17.0, uses the frozen install flags, and fails closed when the retained readiness evidence bundle is missing. KPI collection, scheduled report-only/manual audit semantics, artifact contents, and external production-evidence requirements remain unchanged.Exact current-head proof
For unchanged exact head
1bf9eb8036669939e9a8f0d759571c81ce5b685aon live protected base2b3eee922efaa7ae2f11040b1a82a2ce305b75c6:cirun31581914055: terminal success; verify job checked out the exact head andrelease verifycompleted successfully;reviewer-cirun31581913986: terminal success;Security Scanrun31581914013: terminal success; OSV, supported dependency-review and Trivy hard jobs completed successfully, with Scorecard remaining posture evidence;Live governance boundary
The observable active Noema ruleset currently requires the central
.github/workflows/security-scan.yml@refs/heads/mainworkflow on the default branch, has no bypass actors, and does not currently contain a pull-request approval rule. This PR therefore does not invent an independent-approval requirement that live policy does not enforce. Any future live governance change must be re-read before merge.Technical GREEN does not establish real production KPI, release publication, deployment, customer/revenue, owner/legal/IP-transfer, or acquisition readiness. No protection weakening, synthetic approval, force push, outbound-license choice, version bump, release, or deployment is introduced.
Related: #145, #3, #5, #27, #29
Summary by CodeRabbit
개선 사항
테스트