fix(kpi): restack fatal UTF-8 threshold input on current main - #210
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughKPI 검사 스크립트가 로그를 fatal UTF-8로 디코딩합니다. 잘못된 입력은 오류와 함께 종료합니다. 통합 테스트는 잘못된 입력과 유효한 KPI 로그 처리를 검증합니다. ChangesKPI 입력 무결성
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant Test
participant check_kpi_mjs
participant KPI_Log
Test->>KPI_Log: 임시 NDJSON 로그 생성
Test->>check_kpi_mjs: subprocess 실행
check_kpi_mjs->>KPI_Log: 로그 바이트 읽기
check_kpi_mjs-->>Test: malformed 입력은 stderr 오류와 실패 상태 반환
check_kpi_mjs-->>Test: 유효 입력은 KPI 결과와 성공 상태 반환
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh protected-main successor for #127 on exact base
15e47db4c4429df3a64d9e5eefb77f9d7598eaf1. No predecessor checks, reviews, scanner output, model judgment, KPI production evidence, or acquisition evidence transfers.Test-first RED head
6931f55403f51d0b0db8900c20fba77c10866136adds only the executable malformed-UTF-8 and valid-threshold regressions. Protectedscripts/check-kpi.mjsstill decodes retained bytes withreadFile(..., "utf8"), so malformed bytes can replacement-normalize before threshold/window semantics.After exact RED proof, the bounded GREEN is to read exact bytes and decode with fatal UTF-8 before line/JSON semantics, preserving threshold, window, route, and non-JSON filtering behavior.
Historical #127 remains open until this successor proves and integrates the complete two-file contract.
Summary by CodeRabbit
버그 수정
테스트