Skip to content

fix(review): 리뷰 거버넌스 순환 대기 해소#17

Open
seonghobae wants to merge 1 commit into
mainfrom
agent/noema-break-governance-cycle
Open

fix(review): 리뷰 거버넌스 순환 대기 해소#17
seonghobae wants to merge 1 commit into
mainfrom
agent/noema-break-governance-cycle

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

문제

Noema가 모든 non-OpenCode current-head check 완료를 기다리면서, 정작 리뷰 결과를 소비하는 metadata-only gate evaluation도 선행조건으로 취급했습니다. 이 메타데이터 게이트는 OpenCode 또는 구조화 리뷰 승인을 기다리므로 Noema와 상호 대기합니다.

수정

  • opencode-review와 metadata-only gate evaluation의 정확한 이름만 review-dependent check로 제외
  • 유사 이름의 실패 check는 계속 차단
  • 워크플로 계약 및 deterministic gate 회귀 테스트 추가
  • 대기 로그를 review-independent 의미로 명확화

검증

  • reviewer pytest: 87 passed, line/branch coverage 100%
  • interrogate: docstring coverage 100%
  • actionlint: central-review.yml 통과
  • git diff --check 통과

@cwl-noema-review cwl-noema-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noema PydanticAI review

The PR resolves a circular wait problem in the central review workflow by precisely excluding only the checks ("opencode-review" and "metadata-only gate evaluation") that directly depend on the reviewer as upstream inputs. The gating logic is updated to reflect this, with both the code and central-review.yml changed accordingly. Additional tests confirm correct contract enforcement for these exceptions, and regression tests verify that similarly-named but non-exact checks remain blocking. All current checks pass, no security or dependency findings are open, and test coverage is robust for the gating logic. Approving.

Findings

  • No blocking findings.

  • Result: APPROVE

  • Verdict: approve

  • Confidence: high

  • Head SHA: 3e733119ab6cd4342d644a09a000113ceb2620d1

  • Reviewer credential: noema-github-app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant