Inkspan: fix build defect, bundle offline multilingual fonts, product branding#1
Conversation
…nkspan Build fix (blocking): - Add @types/node (pinned 20.19.9) to devDependencies. tsconfig sets types:['vitest/globals','node'] but @types/node was missing, so tsc failed with TS2688 and pnpm build/typecheck were broken. Now typecheck, library build, converter build, demo build and the test suite all pass. Bundled offline fonts (air-gapped / 폐쇄망, SIL OFL 1.1): - Ship self-contained Noto Sans woff2 covering Korean, English, Japanese, Chinese (Simplified + Traditional) and Vietnamese under src/fonts/files/ (~9.7 MB, ~470 unicode-range subset files). @font-face CSS references only local bundled files — no CDN / Google Fonts URL, zero network fetch to render. - Add src/fonts/fonts.css (all five scripts) and src/fonts/fonts-latin.css (Latin/Vietnamese only) so consumers can tree-shake the CJK fonts. - Add scripts/fetch-fonts.mjs generator (the only step that touches the network; rendering never does) and a `pnpm fonts` script. - Apply a Noto Sans default font stack via --cwl-font in styles.css. - Include OFL.txt license text + NOTICE attribution; note MIT/OFL compatibility. - Export ./fonts.css, ./fonts-latin.css, ./fonts/* from package.json; mark CSS as sideEffects so consumer bundlers keep the imports. - Demo imports fonts.css and shows all five scripts; built demo has 0 CDN refs. Product branding — Inkspan (inkspan.io): - Brand README (title/description), package.json description/keywords, demo, and docs as Inkspan. Repo slug stays cwl-editor; npm name unchanged. Minor fixes: - Base64Image: remove the docstring's non-existent `fetchRemote` option (remote fetch conflicts with the offline base64-inline design) and clarify intent. - imageFileToInlineDataUri: re-apply the maxSizeBytes guard to the re-encoded output after canvas downscale, so the size guard covers what actually lands in the document. Add tests (49 tests pass). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTAMs4bpSZS77Xe3RQjv9P
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
# Conflicts: # package.json # pnpm-lock.yaml # src/extensions/Base64Image.test.ts
There was a problem hiding this comment.
Pull request overview
OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.
Findings
No blocking findings.
Evidence
- Result: APPROVE
- Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
- Scope:
unsupported - Changed files:
0 - Model-pool outcome:
exhausted - Head SHA:
58e30952b8517b5f58f2b8bee16fde43d025b440 - Workflow run: 29201473144
- Workflow attempt: 1
This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.
Summary
Fixes the blocking build defect, ships bundled offline multilingual fonts, and brands the product as Inkspan (inkspan.io). Repo slug stays
cwl-editor.1. Build fix (blocking, confirmed)
tsconfig.jsonsetstypes: ['vitest/globals', 'node']but@types/nodewas not indevDependencies, sopnpm typecheck/pnpm buildfailed with TS2688. Added@types/nodepinned (20.19.9). Now typecheck, library build, converter build, demo build, and the test suite all pass.2. Bundled offline fonts (air-gapped / 폐쇄망)
src/fonts/files/— ~9.7 MB across ~470unicode-rangesubset files.@font-faceCSS references only local bundled files (./files/…) — no CDN / Google Fonts URL. Verified the built demo has 0gstatic/googleapisreferences → renders with zero network fetch.src/fonts/fonts.css(all five scripts) andsrc/fonts/fonts-latin.css(Latin/Vietnamese only) so consumers can tree-shake / opt out of CJK.scripts/fetch-fonts.mjsregenerates the bundle (the only step that touches the network; rendering never does) +pnpm fonts.--cwl-fontNoto Sans stack instyles.css.src/fonts/OFL.txtlicense +src/fonts/NOTICEattribution; MIT/OFL compatibility documented.3. Product branding — Inkspan
README (title/description),
package.jsondescription + keywords, demo UI, and docs branded as Inkspan (inkspan.io). npm name and repo slug unchanged.4. Minor fixes
Base64Image: removed the docstring's non-existentfetchRemoteoption (remote fetch conflicts with the offline base64-inline design); clarified intent.imageFileToInlineDataUri: re-applies themaxSizeBytesguard to the re-encoded output after canvas downscale, so the guard covers what actually lands in the document. Added tests.Verification
pnpm install && pnpm typecheck && pnpm build && pnpm build:demo— all green.pnpm test— 49 passed (was 45).Licensing
Code MIT; fonts OFL-1.1 (permissive, non-copyleft, MIT-compatible — fonts are content, not linked code). No GPL/AGPL.
🤖 Generated with Claude Code