π¨ Palette: λΉλκΈ° λ²νΌ λ‘λ© μνμ μΉ μ κ·Όμ±(aria-busy) κ°μ #180
π¨ Palette: λΉλκΈ° λ²νΌ λ‘λ© μνμ μΉ μ κ·Όμ±(aria-busy) κ°μ #180seonghobae wants to merge 1 commit into
aria-busy) κ°μ #180Conversation
- λΉλκΈ° μμ (`submitDocument`, `loadDemoData`, `refreshKpiEvidence`, `retryActiveJob`, `Details` νΈλ€λ¬) μ μ€ν¬λ¦° 리λ λ± λ³΄μ‘° κΈ°μ μ΄ λ‘λ© μνλ₯Ό μ¬λ°λ₯΄κ² μΈμ§ν μ μλλ‘ λͺ μμ μΌλ‘ `aria-busy="true"`λ₯Ό λΆμ¬ν¨. - `finally` λΈλ‘μμ μμ νκ² μμ±μ μ κ±°νμ¬ μμ 볡ꡬν¨. - `demo.js`μ λ²νΌ ν΄λ¦ λ‘λ© μνμ κ΄ν μΉ μ κ·Όμ± ν₯μ.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: λΉλκΈ° λ²νΌλ€μ΄ λ‘λ© μνμΌ λ(μ: "Submitting...", "Refreshing...")
aria-busy="true"μμ±μ λμ μΌλ‘ μ€μ νκ³ , ν΅μ μλ£ νfinallyλΈλ‘μμ μ κ±°νλ μ½λλ₯Ό μΆκ°νμ΅λλ€.π― Why: μκ°μ μΌλ‘ ν μ€νΈκ° λ³κ²½λκ±°λ λ²νΌμ΄ λΉνμ±νλλ κ²λ§μΌλ‘λ μ€ν¬λ¦° 리λμ κ°μ 보쑰 κΈ°κΈ°κ° μμμ λ‘λ© μνλ₯Ό λͺ ννκ² μΈμ§νκΈ° μ΄λ ΅μ΅λλ€.
aria-busyμμ±μ ν΅ν΄ μ κ·Όμ±μ ν₯μμν€κ³ μ¬μ©μ νΌλμ λ°©μ§ν©λλ€.βΏ Accessibility: λ‘λ© μνλ₯Ό λνλ΄λ νμ€ ARIA μμ±μΈ
aria-busyλ₯Ό μ μ ν νμ©νμ¬ μ κ·Όμ± κΈ°μ€μ μΆ©μ‘±νμ΅λλ€.πΈ Before/After: ν μ€νΈ μ½λλ₯Ό ν΅ν΄ μ±κ³΅μ μΌλ‘ μμ±μ΄ λμ ν λΉ λ° ν΄μ λ¨μ μ¦λͺ νλ Playwright κ²μ¦ λΉλμ€μ μ€ν¬λ¦°μ·μ 첨λΆνμ΅λλ€.
PR created automatically by Jules for task 4047901148293944264 started by @seonghobae