Skip to content

๐ŸŽจ Palette: ContextSection ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #249

Closed
seonghobae wants to merge 1 commit into
developmentalfrom
palette-context-section-a11y-18012545701253563778
Closed

๐ŸŽจ Palette: ContextSection ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #249
seonghobae wants to merge 1 commit into
developmentalfrom
palette-context-section-a11y-18012545701253563778

Conversation

@seonghobae

Copy link
Copy Markdown

๐Ÿ’ก What:
ContextSection ์•„์ฝ”๋””์–ธ ์ปดํฌ๋„ŒํŠธ์˜ ํ† ๊ธ€ ๋ฒ„ํŠผ์— ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ์Šคํƒ€์ผ(focus-visible)์„ ์ถ”๊ฐ€ํ•˜๊ณ , ์ปจํ…์ธ  ์˜์—ญ๊ณผ ๋ฒ„ํŠผ์„ aria-controls๋กœ ์—ฐ๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ ์žฅ์‹์šฉ ์•„์ด์ฝ˜์€ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ ์ฝํžˆ์ง€ ์•Š๋„๋ก aria-hidden="true" ์†์„ฑ์„ ๋ถ€์—ฌํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why:
๊ธฐ์กด ํ† ๊ธ€ ๋ฒ„ํŠผ์€ hover ์‹œ๊ฐ์  ํšจ๊ณผ๋งŒ ์žˆ์–ด ํ‚ค๋ณด๋“œ(Tab ํ‚ค)๋กœ ์ ‘๊ทผ ์‹œ ํ˜„์žฌ ํฌ์ปค์Šค ์œ„์น˜๋ฅผ ์•Œ ์ˆ˜ ์—†์—ˆ์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ๋ฒ„ํŠผ์ด ์–ด๋А ์˜์—ญ์„ ์ œ์–ดํ•˜๋Š”์ง€(Context) ๋ช…ํ™•ํžˆ ์•Œ๊ธฐ ์–ด๋ ต๊ณ  ๋ฌด์˜๋ฏธํ•œ ์•„์ด์ฝ˜("ChevronUp", "ChevronDown") ํ…์ŠคํŠธ๊ฐ€ ์ฝํžˆ๋Š” ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค. ์ด๋ฅผ ๊ฐœ์„ ํ•˜์—ฌ ์•ฑ์˜ ์ ‘๊ทผ์„ฑ์„ ๋†’์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After:

  • Before: ํ‚ค๋ณด๋“œ๋กœ ํƒญ ์ด๋™ ์‹œ ํ† ๊ธ€ ๋ฒ„ํŠผ์— ์•„๋ฌด๋Ÿฐ ์‹œ๊ฐ์  ๋ณ€ํ™” ์—†์Œ, ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ ์•„์ด์ฝ˜ ์ด๋ฆ„ ์ฝ์Œ.
  • After: ํ‚ค๋ณด๋“œ๋กœ ํƒญ ์ด๋™ ์‹œ ๋ฒ„ํŠผ ์ฃผ๋ณ€์— ๋šœ๋ ทํ•œ ํฌ์ปค์Šค ๋ง ์ƒ์„ฑ, ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ํ™˜๊ฒฝ ์ตœ์ ํ™”(์˜๋ฏธ ์—†๋Š” ์•„์ด์ฝ˜ ๋ฌด์‹œ, ์ปจํŠธ๋กค ์˜์—ญ ์—ฐ๊ฒฐ).

โ™ฟ Accessibility:

  • React useId()๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์•ˆ์ •์ ์ด๊ณ  ๊ณ ์œ ํ•œ ID๋ฅผ ์ƒ์„ฑํ•ด aria-controls์™€ ์ปจํ…Œ์ด๋„ˆ์˜ id๋ฅผ ์—ฐ๊ฒฐ.
  • Tailwind์˜ focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:rounded-sm๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์‹œ๊ฐ์  ํฌ์ปค์Šค ์ธ๋””์ผ€์ดํ„ฐ ์ œ๊ณต.
  • ์žฅ์‹์šฉ lucide-react ์•„์ด์ฝ˜(ChevronUp, ChevronDown)์— aria-hidden="true" ์†์„ฑ ๋ถ€์—ฌ.

PR created automatically by Jules for task 18012545701253563778 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Author

Superseded by #235: same ContextSection accessibility improvement (useId + aria-controls/aria-labelledby + role=region + focus-visible ring) with real jsdom component tests.

@seonghobae seonghobae closed this Jul 13, 2026
@seonghobae seonghobae deleted the palette-context-section-a11y-18012545701253563778 branch July 13, 2026 05:25
@google-labs-jules

Copy link
Copy Markdown

Superseded by #235: same ContextSection accessibility improvement (useId + aria-controls/aria-labelledby + role=region + focus-visible ring) with real jsdom component tests.

Understood. Acknowledging that this work is superseded by #235 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant